Skip to content

statistics: add more write query kind (#4011) #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 13, 2021
Merged

statistics: add more write query kind (#4011) #4028

merged 7 commits into from
Oct 13, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4011

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

add more write query kind for hot region scheduler

What is changed and how it works?

insert 1200 tables
image

write test with Pessimistic

image

image

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

lhy1024 added 6 commits August 24, 2021 10:08
@lhy1024 @ti-chi-bot
scheduler: add more write query kind
f888d49 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 @ti-chi-bot
update kvproto
7c571a2 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 @ti-chi-bot
update
10c00cc 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 @ti-chi-bot
update
e14c8a2 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 @ti-chi-bot
address comment
6988695 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 @ti-chi-bot
add comments
c6948cd 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 24, 2021
Merged
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 24, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. component/statistics Statistics for scheduling. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick. labels Aug 24, 2021
@ti-chi-bot ti-chi-bot requested review from lhy1024 and rleungx August 24, 2021 10:08
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 24, 2021
@lhy1024
Copy link
Contributor

lhy1024 commented Aug 24, 2021

/rebuild

@codecov
Copy link

codecov bot commented Aug 24, 2021 •
edited
Loading

Codecov Report

Merging #4028 (aef330f) into release-5.2 (46534a1) will increase coverage by 0.08%.
The diff coverage is 90.90%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.2    #4028      +/-   ##
===============================================
+ Coverage        74.73%   74.81%   +0.08%     
===============================================
  Files              249      249              
  Lines            25582    25611      +29     
===============================================
+ Hits             19118    19161      +43     
+ Misses            4783     4774       -9     
+ Partials          1681     1676       -5
Flag Coverage Δ
unittests 74.81% <90.90%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/test_util.go 81.08% <89.47%> (+4.36%) ⬆️
pkg/mock/mockcluster/mockcluster.go 95.21% <100.00%> (-0.05%) ⬇️
server/core/region.go 91.53% <100.00%> (+0.01%) ⬆️
server/core/region_option.go 85.10% <100.00%> (-0.90%) ⬇️
server/id/id.go 76.19% <0.00%> (-9.53%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/region_syncer/server.go 83.08% <0.00%> (-5.89%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/server.go 71.58% <0.00%> (-0.76%) ⬇️
server/cluster/coordinator.go 73.15% <0.00%> (-0.68%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46534a1...aef330f. Read the comment docs.

@lhy1024 lhy1024 added this to the v5.2.1 milestone Sep 1, 2021
nolouch
nolouch reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Write Leader can priority to choose QPS dimension, it's simpler than read request like coprocessor

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 12, 2021
@nolouch
Copy link
Contributor

nolouch commented Oct 13, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c6948cd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
@ti-chi-bot ti-chi-bot merged commit 9a97fe1 into tikv:release-5.2 Oct 13, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.2.1, v5.2.2 Oct 20, 2021
This was referenced Oct 21, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@lhy1024 lhy1024

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/statistics Statistics for scheduling. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @lhy1024 @nolouch @zhouqiang-cl