Skip to content

TestMixedTSODeployment has random failures due to data race in lease #6378

@binshi-bing

Description

@binshi-bing

Flaky Test

Which jobs are failing

TestMixedTSODeployment

WARNING: DATA RACE
Write at 0x00c008ac3838 by goroutine 482457:
github.com/tikv/pd/pkg/election.(*lease).Grant()
/Users/binshi/code/pingcap/my-pd/pkg/election/lease.go:67 +0x4b8
github.com/tikv/pd/pkg/election.(*Leadership).Campaign()
/Users/binshi/code/pingcap/my-pd/pkg/election/leadership.go:111 +0x214
github.com/tikv/pd/pkg/member.(*EmbeddedEtcdMember).CampaignLeader()
/Users/binshi/code/pingcap/my-pd/pkg/member/member.go:168 +0x228
github.com/tikv/pd/server.(*Server).campaignLeader()
/Users/binshi/code/pingcap/my-pd/server/server.go:1451 +0x198
github.com/tikv/pd/server.(*Server).leaderLoop()
/Users/binshi/code/pingcap/my-pd/server/server.go:1445 +0x9c0
github.com/tikv/pd/server.(*Server).startServerLoop.func1()
/Users/binshi/code/pingcap/my-pd/server/server.go:565 +0x34

Previous read at 0x00c008ac3838 by goroutine 488107:
github.com/tikv/pd/pkg/election.(*lease).Close()
/Users/binshi/code/pingcap/my-pd/pkg/election/lease.go:83 +0xc8
github.com/tikv/pd/pkg/election.(*Leadership).Reset()
/Users/binshi/code/pingcap/my-pd/pkg/election/leadership.go:236 +0xd0
github.com/tikv/pd/pkg/member.(*EmbeddedEtcdMember).ResetLeader()
/Users/binshi/code/pingcap/my-pd/pkg/member/member.go:249 +0x38
github.com/tikv/pd/tests.(*TestServer).ResignLeader()
/Users/binshi/code/pingcap/my-pd/tests/cluster.go:155 +0x9c
github.com/tikv/pd/tests/integrations/tso.TestMixedTSODeployment.func1()
/Users/binshi/code/pingcap/my-pd/tests/integrations/tso/client_test.go:270 +0xe8

CI link

local run:
under pd/tests/integrations/tso, run "make test"

Reason for failure (if possible)

data race in lease.go. The log shown above is clear.

Anything else

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/ciThe issue is related to CI.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions