Skip to content

Conversation

overvenus
Copy link
Member

No description provided.

@overvenus overvenus requested review from siddontang and BusyJay July 6, 2017 03:20
@@ -342,7 +342,10 @@ pub struct Client {

impl Client {
pub fn new(cfg: &ClientConfig) -> Client {
let env = Arc::new(EnvBuilder::new().build());
let mut env = EnvBuilder::new();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a builder not an env.

@BusyJay
Copy link
Member

BusyJay commented Jul 6, 2017

LGTM

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang siddontang merged commit 0d3b2db into master Jul 6, 2017
@siddontang siddontang deleted the ov/bench branch July 6, 2017 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants