Skip to content

Conversation

lchojnack
Copy link
Contributor

Change the camera image resolution from 1280x720 to 1920x1080 and the camera focal length from 20mm to 35mm

The changes improve the yellow traffic light recognition, mentioned in #10

Before changes

before_changes.mp4

After changes

after_changes.mp4

@lchojnack lchojnack requested a review from mackierx111 January 3, 2023 09:06
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for @mackierx111 review.

@mackierx111
Copy link
Collaborator

mackierx111 commented Apr 3, 2023

LGTM !
but, I will merge this pull request after awsim-stable branch reflects the parameters regarding Autoware's traffic light vibration.
autowarefoundation/autoware_universe#3189

@mackierx111 mackierx111 marked this pull request as draft April 3, 2023 17:22
@shmpwk shmpwk marked this pull request as ready for review April 5, 2023 10:07
@shmpwk
Copy link
Contributor

shmpwk commented Apr 5, 2023

Merge this because awsim-stable branch reflects this change.

@shmpwk shmpwk merged commit 42d2053 into main Apr 5, 2023
@mackierx111 mackierx111 deleted the feature/improve-yellow-light-recognition-main branch April 7, 2023 01:14
xmfcx added a commit to xmfcx/AWSIM that referenced this pull request Apr 30, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
tzu-lin-huang pushed a commit to OptiVerse-Technology-Ltd/AWSIM that referenced this pull request Aug 26, 2025
Co-authored-by: mackierx111 <mackierx111@gmail.com>
tzu-lin-huang pushed a commit to OptiVerse-Technology-Ltd/AWSIM that referenced this pull request Aug 26, 2025
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants