Creates a constant for maximum and minimum JSON Integers and documents them #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't tell if this change fixes anything. It looks unnecessary. Does it address a specific problem? |
No it's just for documentation, doesn't fix anything specific, Not a priority. Let me know if I can make any changes to make it clear, Just thought it would be useful |
|
@tidwall |
|
I would prefer to keep the numbers hardcoded. Adding constants are not needed imo. But I don't mind if you added a comment above the line that includes the links to the https://tc39.es/ecma262 page. |
|
@tidwall Thanks, have made the change |
|
👍 Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates constants for maximum and minimum safe Integers in JSON and documents them as per: