fix(test): do not use loopback IP for IMAP connectivity test #9401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a local IMAP server on the development host, the "open() with connection error should throw" IMAP test will succeed connecting to the IMAP server, thus making the test fail. This patch changes the use of a loopback IP address (127.1.2.3) to a non-routable RFC-5737 TEST-NET-1 address (192.0.2.123). Fixes: #9400
|
Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 12. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a local IMAP server on the development host, the
open() with connection error should throwIMAP test will succeed connecting to the IMAP server, thus making the test fail.This patch changes the use of a loopback IP address (127.1.2.3) to a non-routable RFC-5737 TEST-NET-1 address (192.0.2.123).
Fixes: #9400