Skip to content

Remove deprecated Window.FEATURE_INDETERMINATE_PROGRESS request. #9090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Remove deprecated Window.FEATURE_INDETERMINATE_PROGRESS request. #9090

merged 1 commit into from
May 1, 2025

Conversation

Fishkin
Copy link
Contributor

@Fishkin Fishkin commented Apr 30, 2025

Fixes #9068

@Fishkin Fishkin mentioned this pull request Apr 30, 2025
Closed
2 tasks
@kewisch kewisch assigned rafaeltonholo and unassigned asoucar Apr 30, 2025
rafaeltonholo
rafaeltonholo requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fishkin, thank you for your contribution. I have left two comments for your review.

@Fishkin Fishkin changed the title Ignore indeterminate progress exceptions. Remove deprecated Window.FEATURE_INDETERMINATE_PROGRESS request. Apr 30, 2025
@Fishkin
Copy link
Contributor Author

Fishkin commented Apr 30, 2025

Hi @Fishkin, thank you for your contribution. I have left two comments for your review.

Thanks, I removed them now in new push, is that what you meant?

@rafaeltonholo
Copy link
Member

Hi @Fishkin, thank you for your contribution. I have left two comments for your review.

Thanks, I removed them now in new push, is that what you meant?

Yes, that is it! Thank you

rafaeltonholo
rafaeltonholo approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution :)

@rafaeltonholo rafaeltonholo merged commit b0eb5e9 into thunderbird:main May 1, 2025
3 checks passed
@thunderbird-botmobile
Copy link
Contributor

Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 11. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org
Hope to see you there! 🚀📱🐦

@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 11 milestone May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeltonholo rafaeltonholo rafaeltonholo approved these changes

@kewisch kewisch Awaiting requested review from kewisch

@wmontwe wmontwe Awaiting requested review from wmontwe

@asoucar asoucar Awaiting requested review from asoucar

Assignees

@rafaeltonholo rafaeltonholo

Labels
None yet
Projects
None yet
Milestone
Thunderbird 11
Development

Successfully merging this pull request may close these issues.

Compose crashes on an Android Watch
3 participants
@Fishkin @rafaeltonholo @asoucar