Skip to content

1 update dockerfile #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2025
Merged

1 update dockerfile #115

merged 3 commits into from
Jun 1, 2025

Conversation

garethm
Copy link
Contributor

@garethm garethm commented Jun 1, 2025

Updates to Dockerfile:

  • Updated base images to currently recommended versions
  • Moved MAINTAINER so that Author field is set in final image rather than on build image
  • Added author LABEL which is the recommended way to set the author
  • Create non-root user for runtime which is a recommended container best practice (e.g. semgrep missing-user-entrypoint rule)

@xntrik
Copy link
Collaborator

xntrik commented Jun 1, 2025

Awesome. Thanks @garethm

@xntrik xntrik self-requested a review June 1, 2025 01:38
@xntrik xntrik merged commit e17bae6 into threatcl:main Jun 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xntrik xntrik xntrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garethm @xntrik