Add go-redis support #37
Conversation
4e839fe to
0ddac0c
Compare
There was a problem hiding this comment.
Thank you @kerkerj — nice work!
This looks solid to me (minus the one comment below). There's quite a bit of duplication with the code in redigostore, but most of the strikes me as okay given that its somewhat inevitable and its implementation has been demonstrated to be quite stable.
We should probably put redisCASScript in a shared package so that it's not repeated like this, but I don't feel particularly strongly about it given that the naming for a the new package will be somewhat awkward, will force us to export it publicly, and that the script never changes anyway.
@metcalf Any feelings on this one? If not, I'll pull it in soon after the minor fix above is made.
| ) | ||
|
|
||
| // Demonstrates that how to initialize a RateLimiter with redis | ||
| // using go-redis libaray. |
There was a problem hiding this comment.
Thanks for the example! Typo here: "library".
0ddac0c to
622f6fb
Compare
|
Thanks again! Pulling this in. |
It's good hygiene to maintain a changelog so that people can figure out what changed. This one adds a basic version with an entry for the upcoming 2.2.0 that will include #37.
It's good hygiene to maintain a changelog so that people can figure out what changed. This one adds a basic version with an entry for the upcoming 2.2.0 that will include #37.
It's good hygiene to maintain a changelog so that people can figure out what changed. This one adds a basic version with an entry for the upcoming 2.2.0 that will include #37.
|
Released as |
Add
go-redislibrary support, please take a look. :)