Setup minimum bound to Go 1.18 #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3044d84 to
6d7d29b
Compare
Set minimum Go version to 1.18 to enable pruning as described by #109. 1.18 is already ancient in its own respect, so the good procured by making it the minimum far outweighs any compatibility problems. Update the build matrix to use the latest Go 1.25 and next latest versions of 1.24 and 1.23. Add 1.18 in there as well to make sure that actually works. I originally had this set to minimum of Go 1.17 because that's the version where module pruning was introduced, but it turns out that all kinds of dependencies are using functions like `strings.Cut` that were introduced in 1.18. Do 1.18 instead to make this easier. Fixes #109.
6d7d29b to
846d99d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set minimum Go version to 1.18 to enable pruning as described by #109.
1.18 is already ancient in its own respect, so the good procured by
making it the minimum far outweighs any compatibility problems.
Update the build matrix to use the latest Go 1.25 and next latest
versions of 1.24 and 1.23. Add 1.18 in there as well to make sure that
actually works.
I originally had this set to minimum of Go 1.17 because that's the
version where module pruning was introduced, but it turns out that all
kinds of dependencies are using functions like
strings.Cutthat wereintroduced in 1.18. Do 1.18 instead to make this easier.
Fixes #109.