Add store for go-redis.v9 #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
added a commit
that referenced
this pull request
Jun 29, 2023
Proximate impetus is trying to support go-redis.v9 in #103, which uses some more modern Go conventions like `strings.Cut` and `time.UnixMillis` which won't build prior to 1.18 and 1.17 respectively. Go technically supports only the last two versions (1.19 and 1.20), and 1.21 has a release candidate so even 1.19 is about to drop. Let's try not to be quite that aggressive, but drop everything up to 1.18.
|
This is having trouble on the older versions in the build matrix because the new go-redis uses newer Go functions like |
|
Released as 2.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.