Introduce context.Context in function signatures #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is blocking this PR to be merged? |
This allows the usage of stores that use a context, for example to cancel a request or to perform tracing. All functions and interfaces that have changed signatures, have Ctx as a suffix to maintain full backwards compatibility and provide a smooth migration path.
|
Took me a while to get to it, but both branches are up-to-date again. First merging this one and then #84 should do the trick. |
|
@brandur Is there anything left to get this merged? |
|
Doh, sorry @jpcoenen — dropped this again. I looked through this and it seems solid. I think it'd be a little surprising for people when they find out that the stores don't really do anything with the context, but it's still movement in the right direction and updating the stores will chunk out nicely as separate work. |
brandur
added a commit
that referenced
this pull request
Mar 25, 2023
A few extra newlines and line wrapping in the README to follow up new changes in #83 and fit other convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the usage of stores that use a context, for example to cancel a request or to perform tracing. Saw this being discussed in #67 and #57.
All functions and interfaces that have changed signatures, have Ctx as a suffix to maintain full backwards compatibility and provide a smooth migration path. Or at least... I think so.
Not all context's are actually used yet. All the old stores just use an adapter around the old store that silently drops the provided context. But having it in the signature, allow the stores to be changed gradually. And I also have a PR incoming for using it with
redis-go.v8.Documentation can maybe use some work. So any suggestions regarding this or any feedback on the used approach are very welcome!