Revert upgrade to go-redis v8 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts the upgrade to go-redis v8 that I made a few days ago because in retrospect, it seems likely to cause more problems than it solves. I'd thought that going to v8 was somewhat unpreventable because it was their `master` branch, but the main problem seems to have been that this project was not on Go Modules. Now that it is, go-redis v6 gets pulled by default, and an explicit major needs to be specified to get anything later. Also, according to the go-redis CHANGELOG, v8 is not yet released. I'm not sure what the best course of action is going forward, but it may be that we should release new stores to support new majors from the supported adapters. There may be a better way, but I'm not sure what it is yet.
1fb8e71 to
7ad8a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the upgrade to go-redis v8 that I made a few days ago because in
retrospect, it seems likely to cause more problems than it solves.
I'd thought that going to v8 was somewhat unpreventable because it was
their
masterbranch, but the main problem seems to have been that thisproject was not on Go Modules. Now that it is, go-redis v6 gets pulled
by default, and an explicit major needs to be specified to get anything
later.
Also, according to the go-redis CHANGELOG, v8 is not yet released.
I'm not sure what the best course of action is going forward, but it may
be that we should release new stores to support new majors from the
supported adapters. There may be a better way, but I'm not sure what it
is yet.