Add context objects to goredis calls #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is currently broken because goredis changed their API in a few ways -- mostly adding context objects to all calls, but also with a few minor type changes. We'll want to have a better versioning strategy at some point here, but for now, we update our goredis adapter to be compatible.
Drops support for Go 1.11 because goredis is no longer compatible with it. Although we aim for good long-term support, given how old this version of Go is, this seems like the easiest course of action.
Unfortunately, its exit code was not being checked in CI so this problem has never been picked up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is currently broken because goredis changed their API in a few
ways -- mostly adding context objects to all calls, but also with a few
minor type changes.
We'll want to have a better versioning strategy at some point here, but
for now, we update our goredis adapter to be compatible.