Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

s3_protocol default could be more sensible #2038

@hannesfostie

Description

@hannesfostie

Hi,

I just spent a little while trying to figure out why my Attachment URLs were http instead of https. I started looking in my AWS config at first, where HTTPS is the default, and then finally came across the Paperclip documentation which states the following:

    # * +s3_protocol+: The protocol for the URLs generated to your S3 assets. Can be either
    #   'http', 'https', or an empty string to generate protocol-relative URLs. Defaults to 'http'
    #   when your :s3_permissions are :public_read (the default), and 'https' when your
    #   :s3_permissions are anything else.

I don't quite see why we'd want to default to http based on s3_permissions. If anything, we should look at the AWS settings and use that protocol?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions