Skip to content

Conversation

gingerlime
Copy link
Contributor

  • converted from .travis.yml
  • removed .travis.yml

@gingerlime
Copy link
Contributor Author

unfortunately the rails 6.0 tests are failing, but I'm not really sure why. See https://github.com/gingerlime/clearance/actions/runs/473819643

@gingerlime
Copy link
Contributor Author

looks like travis also fails with rails 6.0 https://travis-ci.org/github/thoughtbot/clearance/builds/753660714

@eebs eebs force-pushed the github_actions branch 4 times, most recently from e0fbdb1 to 584da78 Compare January 15, 2021 19:36
@eebs
Copy link
Contributor

eebs commented Jan 15, 2021

Thank you @gingerlime this is fantastic. The last Travis run for a different PR took over 2 hours to complete, it looks like with GitHub Actions they all run collectively in under 2 minutes. 🎉

I think because it's a PR the actions are running on your fork and not showing here, but I assume once this is merged they'll appear within this repo. There was one failure but I believe this to be unrelated to this PR so I'm going to go ahead and merge this.

Thanks again for taking the time to improve Clearance!

@eebs eebs merged commit 728bf9d into thoughtbot:master Jan 15, 2021
@gingerlime
Copy link
Contributor Author

My pleasure, @eebs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants