Allow boolean values to be represented by numbers #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 do we have a test that can demo this? and possibly a number that fails (if that exists) |
|
Test should be straightforward, just parse this JSON, both as {
"realBool": true,
"numberBool": 1
}As for failure, I can't really think of one for the number case, as any number this isn't 0 ( |
6e694bf to
651e3b8
Compare
| let bool: Bool | ||
| let number: Bool | ||
|
|
||
| static func decode(j: JSON) -> Decoded<Booleans> { |
There was a problem hiding this comment.
Variable Name Violation: Variable name should be between 3 and 40 characters long: 'j' (variable_name)
|
Added a success test and fixed the build by writing code that actually compiles (which seemed useful) |
Servers commonly represent boolean values as numbers even though this is clearly wrong and they should be sending `true`/`false`. Anyway, we can make it easier to deal with this by allowing numbers to represent boolean values as well. This essentially fixes compatibility with earlier versions of Argo, which did this anyway.
2c7594c to
a7ca3b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servers commonly represent boolean values as numbers even though this is
clearly wrong and they should be sending
true/false.Anyway, we can make it easier to deal with this by allowing numbers to
represent boolean values as well. This essentially fixes compatibility
with earlier versions of Argo, which did this anyway.
Fixes #358