Ignore scoped files anywhere in repo #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node_modules should not be checked into git. If you do this and would like to continue to ignore it, create a fileignoreconfig in .talismanrc for 'node_modules' Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
When checking if an Addition belongs to any scopes, we should compare just the basename of the Addition instead of using the standard filename/path matching logic. Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike custom fileignores in .talismanrc, all file names ignored by scope configs should be ignored regardless of relative path within repo
Fixes #476