Introduce ignore evaluator #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
ChecksumCalculator uses this list of Additions only to represent the names of all tracked files in the repository. Most Additions (in some cases all) in this list do not have any content. This list of Additions is not considered when generating Checksums, which is handled by the Hasher. Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
The Detectors in the Chain need a ChecksumCompare to decide if Additions should be allowed or not, but instantiating the ChecksumCompare requires information not used in the Chain. Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
b8dd1d5 to
597e5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This elevates and replaces the current ChecksumCompare struct and makes it more capable of making all decisions around what file additions should be ignored by the scan and when.