Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thoughtworks/talisman
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.33.1
Choose a base ref
...
head repository: thoughtworks/talisman
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.33.2
Choose a head ref
  • 7 commits
  • 10 files changed
  • 1 contributor

Commits on Mar 27, 2025

  1. Use afero to read TalismanRC

    This also highlights (and fixes) invalid tests that were only looking at
    newly-written .talismanrc additions.
    
    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    tw-owen-nelson committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    d5c2734 View commit details
    Browse the repository at this point in the history
  2. Test unmarshalling filecontents directly

    This removes the need for setting different repo file readers. Other
    tests still use afero to mock the filesystem and ensure that we can load
    a TalismanRC struct from a .talismanrc file.
    
    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    tw-owen-nelson committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    2e35dfa View commit details
    Browse the repository at this point in the history
  3. Remove methods for setting alternate RC file readers

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    tw-owen-nelson committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    17fcb79 View commit details
    Browse the repository at this point in the history
  4. Organize talismanrc tests

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    tw-owen-nelson committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    06b32c0 View commit details
    Browse the repository at this point in the history
  5. Clarify talismanrc method notes and names

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    tw-owen-nelson committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    8cb7b78 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2025

  1. Use afero helper to update .talismanrc file

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    tw-owen-nelson committed Mar 28, 2025
    Configuration menu
    Copy the full SHA
    0a218e1 View commit details
    Browse the repository at this point in the history
  2. Use file named .talismanrc on in-memory fs for tests

    Because it's an in-memory filesystem, we can just use a file named
    .talismanrc instead of creating and using a temp file.
    
    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    tw-owen-nelson committed Mar 28, 2025
    Configuration menu
    Copy the full SHA
    68191ff View commit details
    Browse the repository at this point in the history
Loading