Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thoughtworks/talisman
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.33.0
Choose a base ref
...
head repository: thoughtworks/talisman
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.33.1
Choose a head ref
  • 16 commits
  • 30 files changed
  • 1 contributor

Commits on Mar 21, 2025

  1. Test that scan mode detects removed secrets 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    5e4a149 View commit details
    Browse the repository at this point in the history

  2. Clarify name of files tracked by ChecksumCalculator 

    ChecksumCalculator uses this list of Additions only to represent the
names of all tracked files in the repository. Most Additions (in some
cases all) in this list do not have any content. This list of Additions
is not considered when generating Checksums, which is handled by the
Hasher.

Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    05a5957 View commit details
    Browse the repository at this point in the history

  3. Inject ChecksumCompare into detector chain 

    The Detectors in the Chain need a ChecksumCompare to decide if Additions
should be allowed or not, but instantiating the ChecksumCompare requires
information not used in the Chain.

Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    90f7c7f View commit details
    Browse the repository at this point in the history

  4. Use ChecksumCompare to make all file ignore decisions 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    e4f5617 View commit details
    Browse the repository at this point in the history

  5. Rename ChecksumCompare to show its role in ignoring files 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    30a71b3 View commit details
    Browse the repository at this point in the history

  6. Introduce interface for IgnoreEvaluator 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    226ef78 View commit details
    Browse the repository at this point in the history

  7. Use an IgnoreEvaluator that checks all files when scanning 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    322f010 View commit details
    Browse the repository at this point in the history

  8. Test that scan+history mode doesn't use ignores in talismanrc 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    61265ad View commit details
    Browse the repository at this point in the history

  9. Load talismanrc the same way regardless of mode 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    1a2bb0d View commit details
    Browse the repository at this point in the history

  10. Remove concept of 'Mode' from TalismanRC 

    TalismanRC represents the version-controlled configurations talisman
should consider when running. It is not responsible for distinguishing
between different ways talisman can be invoked.

Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    8d9244c View commit details
    Browse the repository at this point in the history

  11. Replace IgnoreConfig interface with FileIgnoreConfigs 

    Files outside of talismanrc are using the underlying type to manage
ignoring specific files, so it isn't sufficiently abstracting the
capabilty. This brings persistedRC and TalismanRC closer together.

Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    52542cc View commit details
    Browse the repository at this point in the history

  12. Remove unused field tags 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 21, 2025
    Configuration menu
    Copy the full SHA
    bb33122 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2025

  1. Marshal TalismanRC to suggest checksums 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 25, 2025
    Configuration menu
    Copy the full SHA
    94e78dd View commit details
    Browse the repository at this point in the history

  2. Extend Regexp to support (un)marshalling to/from yaml 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 25, 2025
    Configuration menu
    Copy the full SHA
    e45a9f0 View commit details
    Browse the repository at this point in the history

  3. Add ignores by marshalling a TalismanRC struct 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 25, 2025
    Configuration menu
    Copy the full SHA
    46d79a3 View commit details
    Browse the repository at this point in the history

  4. Remove persistedRC and unmarshal directly into TalismanRC 

    Authored-by: Owen Nelson <owen.nelson@thoughtworks.com>
    @tw-owen-nelson
    tw-owen-nelson committed Mar 25, 2025
    Configuration menu
    Copy the full SHA
    0201425 View commit details
    Browse the repository at this point in the history
Loading