-
-
Notifications
You must be signed in to change notification settings - Fork 84
Fix documentation: Replace non-existent DataSourceGeneratorProperty with ClassDataSource<T> #2929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith ClassDataSource<T> Co-authored-by: thomhurst <30480171+thomhurst@users.noreply.github.com>
Copilot finished work on behalf of
thomhurst
August 16, 2025 15:16
This was referenced Aug 18, 2025
This was referenced Aug 20, 2025
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation referenced
[DataSourceGeneratorProperty<T>]
attribute for nested data source initialization, but this attribute doesn't exist in the codebase. Users trying to follow the documentation examples would encounter compilation errors.Problem
The issue was reported in the nested data sources documentation at https://tunit.dev/docs/test-authoring/nested-data-sources where examples showed:
However,
DataSourceGeneratorProperty
is not implemented in TUnit.Core, causing compilation failures for users following the documentation.Solution
Updated all documentation to use
[ClassDataSource<T>]
which is a real attribute that implementsIDataSourceAttribute
and supports property injection. The corrected pattern is:Changes Made
[DataSourceGeneratorProperty<T>]
with[ClassDataSource<T>]
Verification
PropertyDataSourceInjectionTests.cs
confirm[ClassDataSource<T>]
works correctly for property injectionUsers can now successfully follow the documentation examples for nested data source initialization.
Fixes #2928.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.