This repository was archived by the owner on Mar 4, 2023. It is now read-only.
infoObjSize changed from []int to map[TypeID]int #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 43.70% 43.70%
=======================================
Files 18 18
Lines 2304 2304
=======================================
Hits 1007 1007
Misses 1225 1225
Partials 72 72
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetInfoObjSize() function is controlling if typeID is exists by comparing the typeID value by zero. but ReadCmd (C_RD_NA_1: 0) type has a zero value in the infoObjSize array. so it conflicts that, is value really zero or not exists. So this PR is fixes this problem by changing infoObjSize type from []int to map[TypeID]int. and checking typeID existence by looking second parameter of indexing. map implementation completely fitting with array implementation.