test: update lint CI parameters #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: linting in CI (`golangci-lint`) occasionally times out on Windows (flaky). Most of the time, it's fast enough (~1min). But occasionally it hits the 3 minute timeout. It's somewhat expected that `golangci-lint` is slow: golangci/golangci-lint-action#297 This PR does 3 things: 1. Bump the timeout from 3 to 5 minutes (why solve the problem when you can band-aid it?) 2. Add the `--verbose` flag, so if we start to see this again we'll have much better information with which to figure out what specifically is taking so long. 3. Remove the patch number from the `golangci-lint` version; it's disallowed, according to the `golangci-lint` action README. Fixes theupdateframework#390 (for now). Signed-off-by: Zachary Newman <z@znewman.net>
0048941 to
767dfbe
Compare
mnm678
approved these changes
Sep 21, 2022
trishankatdatadog
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zachary Newman z@znewman.net
Context: linting in CI (
golangci-lint) occasionally times out onWindows (flaky). Most of the time, it's fast enough (~1min). But
occasionally it hits the 3 minute timeout. It's somewhat expected that
golangci-lintis slow:golangci/golangci-lint-action#297
This PR does 3 things:
can band-aid it?)
--verboseflag, so if we start to see this again we'll havemuch better information with which to figure out what specifically is
taking so long.
golangci-lintversion; it'sdisallowed, according to the
golangci-lintaction README.Fixes #390 (for now).