🐛 Fix another webpack 5 deprecation warning #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reece Dunham <me@rdil.rocks>
RDIL
commented
Mar 11, 2021
| target: 'web', | ||
| entry: { | ||
| index: './example/client.jsx', | ||
| }, | ||
| devtool: 'cheap-module-eval-source-map', | ||
| devtool: 'eval-cheap-module-source-map', |
There was a problem hiding this comment.
For testing against webpack 5 to work, this change is required, and the other 2 fix warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just one more to go. This one was just 2
ArraytoSetchanges.Not sure why the lockfile got updated, but I also fixed a typo and some warnings outputted while running the tests.
Why
Its a warning.
Checklist
errorsorwarningsapproved terminologyunit tests, if apply.Emojis for categorizing pull requests:
⚡️ New feature (
:zap:)🐛 Bug fix (
:bug:)🔥 P0 fix (
:fire:)✅ Tests (
:white_check_mark:)🚀 Performance improvements (
:rocket:)🖍 CSS / Styling (
:crayon:)♿ Accessibility (
:wheelchair:)🌐 Internationalization (
:globe_with_meridians:)📖 Documentation (
:book:)🏗 Infrastructure / Tooling / Builds / CI (
:building_construction:)⏪ Reverting a previous change (
:rewind:)♻️ Refactoring (like moving around code w/o any changes) (
:recycle:)🚮 Deleting code (
:put_litter_in_its_place:)