-
Notifications
You must be signed in to change notification settings - Fork 48
Remove node-sass from dependencies #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ok, So, if we want to avoid |
Does this mean that mom install sass --dev is sufficient to replace node-sass with sass? Or, is there an option to specify the sass engine to be used? |
Yes, you have to install Like one of:
Until this is merged, you can try
|
Thank you for the quick reply.
I already have rollup-plug-in-scss installed and set up - thank you for the
additional watch options :)
So if I uninstall node-sass which was auto installed , and install sass
(dart sass) the plugin will pick up and use whichever is available?
Edit: I uninstalled node-sass but it remains in the package-lock as a dependency of this plugin.
Edit 2: I replaced with the @astappiev/rollup-plugin-scss and it seems to run dart sass.
On Sat, Feb 6, 2021 at 1:56 AM Oleh Astappiev ***@***.***> wrote:
Yes, you have to install rollup-plugin-scss *and* sass (or node-sass).
Like one of:
- npm install rollup-plugin-scss sass --save-dev
- npm install rollup-plugin-scss node-sass --save-dev
Until this is merged, you can try
- npm install @astappiev/rollup-plugin-scss sass --save-dev
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABQLVBV3PFTS64ULO763DS5UG3FANCNFSM4VVXIZIQ>
.
--
Sent via mobile.
|
If you use my patched version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind updating the README?
Done |
It is nice that for v3, the dependency is being removed completely. Just a quick question here: In Did something go wrong with the deployment, causing the discrepancy? From the downloaded package.json: {
"_resolved": "https://registry.npmjs.org/rollup-plugin-scss/-/rollup-plugin-scss-2.6.1.tgz",
"dependencies": {
"node-sass": "4",
"rollup-pluginutils": "2"
},
"optionalDependencies": {
"node-sass": "4"
},
} |
Seems to be a "feature": npm/npm#3502 |
|
As described in #61, even after moving
node-sass
to optional dependencies it is still downloaded by npm/yarn.Moving it to peer dependencies solves the issue.
Now users have to specify what package they want to use
sass
ornode-sass
in their projects.