feat: enable rolldown native plugin #3502
Merged
+135
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables native plugin support (via Rolldown) for the Electron Vite setup and refactors the plugin loader to use Vite’s built-in load hook API.
- Switch
plugin-loader.mtsfromcreateFilterto a nativeloadhook withfilterandhandler. - Add
experimental.enableNativePluginflags across all environments inelectron.vite.config.mts. - Restrict
solidPluginto only certain file patterns usingwithFilter.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| vite-plugins/plugin-loader.mts | Replaced custom filter with native load hook object API. |
| electron.vite.config.mts | Added experimental.enableNativePlugin, reorganized imports, and scoped solidPlugin with withFilter. |
Comments suppressed due to low confidence (2)
electron.vite.config.mts:131
- [nitpick] Referencing the HMR bug is helpful, but adding a link to the related issue or a brief summary of the root cause will aid future maintainers in understanding why this conditional is needed.
enableNativePlugin: mode !== 'development', // Disable native plugin in development mode to avoid issues with HMR (bug in rolldown-vite)
electron.vite.config.mts:140
- The second filter entry is a string literal (
'/@solid-refresh'), which may not match as intended. If you need a path-based filter, consider using a regex (e.g./\/\@solid-refresh/) or confirm that the string pattern is valid inwithFilter.
load: { id: [/\.(tsx|jsx)$/, '/@solid-refresh'] },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.