-
Notifications
You must be signed in to change notification settings - Fork 1
Feat: better output for listing LDAP users #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dwgnr
merged 9 commits into
th-nuernberg:main
from
BoolPurist:feat_better_output_ldap_list
Apr 19, 2023
Merged
Feat: better output for listing LDAP users #41
dwgnr
merged 9 commits into
th-nuernberg:main
from
BoolPurist:feat_better_output_ldap_list
Apr 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults Introduced Insta as test dependency for snapshot output testing. Adjusted change log for new table output of LDAP users Documented the usage for Insta in this project
optional: keep ugly machine readable stuff. Might be useful at some point. |
450c9a0
to
b257b8e
Compare
…ap_list' into feat_better_output_ldap_list
@dwgnr merge conflicts resolved |
Attributes for LDAP query are now sorted alphabetically to guarantee always in the same order.
dwgnr
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for draft status
Is already based on PR. Waiting for this PR to be merged
Old output vs new output
New
VS
Old
Dependencies
Introduces 2 dependencies: