Skip to content

Feat: better output for listing LDAP users #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 19, 2023

Conversation

BoolPurist
Copy link
Collaborator

@BoolPurist BoolPurist commented Apr 3, 2023

Reason for draft status

Is already based on PR. Waiting for this PR to be merged

Old output vs new output

New

New

VS

Old

Old

Dependencies

Introduces 2 dependencies:

  • Insta for snapshot testing. Its usage is documented in CHANGELOG.md.
  • prettytable for the new output format of listing LDAP users.

…ults

Introduced Insta as test dependency for snapshot output testing.
Adjusted change log for new table output of LDAP users
Documented the usage for Insta in this project
@BoolPurist BoolPurist changed the title Feat better output for listing LDAP users Feat: better output for listing LDAP users Apr 3, 2023
@dwgnr
Copy link
Collaborator

dwgnr commented Apr 5, 2023

optional: keep ugly machine readable stuff. Might be useful at some point.

@BoolPurist BoolPurist marked this pull request as ready for review April 6, 2023 08:07
@BoolPurist BoolPurist closed this Apr 6, 2023
@BoolPurist BoolPurist force-pushed the feat_better_output_ldap_list branch from 450c9a0 to b257b8e Compare April 6, 2023 08:09
@BoolPurist BoolPurist reopened this Apr 6, 2023
@BoolPurist
Copy link
Collaborator Author

@dwgnr merge conflicts resolved

Copy link
Collaborator

@dwgnr dwgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dwgnr dwgnr merged commit dbca42a into th-nuernberg:main Apr 19, 2023
@BoolPurist BoolPurist deleted the feat_better_output_ldap_list branch April 24, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants