Skip to content

Fix: no unclean aborting process on error for result anymore #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix: no unclean aborting process on error for result anymore #39

merged 1 commit into from
Apr 5, 2023

Conversation

BoolPurist
Copy link
Collaborator

Previously used exit prevents stack unwinding

Removed not needed extra wrapper error type.
Using anyhow error directly provides the following advantages:

  • Access to context and with_context to annotate failure more easily
  • "thiserror" as dependency not needed anymore

@BoolPurist
Fix: no unclean aborting process on error for result anymore
e7c3864 
Previously used exit prevents stack unwinding

Removed not needed extra wrapper error type.
Using anyhow error directly provides the following advantages:

- Access to context and with_context to annotate failure more easily
- "thiserror" as dependency not needed anymore
dwgnr
dwgnr approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@dwgnr dwgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dwgnr dwgnr merged commit 7759781 into th-nuernberg:main Apr 5, 2023
@BoolPurist BoolPurist deleted the fix_better_error_strat branch April 6, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwgnr dwgnr dwgnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoolPurist @dwgnr