overhaul: overhauled CLI args for LDAP, Slurm and Directory #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only options are now to opt in variants. Slurm, ldap and dirs can also be toggled via conf.toml Cli have priority over values from conf.toml Added includes fields for slurm and ldap adjusted README for include_slurm and include_ldap in conf.toml added unit tests Adjusted changelog for change in CLI options (ldap, slurm, dirs)
|
@dwgnr merge conflicts resolved |
|
ok. I'm going to merge this now |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only options are now opt in variants.
Slurm, ldap and dirs can also be toggled via conf.toml Cli have priority over values from conf.toml
Added includes fields for slurm and ldap
adjusted README for include_slurm and include_ldap in conf.toml
added unit tests
Adjusted change log for change in CLI options (ldap, slurm, dirs)
Version bumping
This should be bumped in major version for this beta version zone. 0.X.Y => 0.(X+1).Y
Reason: old Cli options are gone aka only-*. Sub commands now have the toggle option in Cli.
Added dependency
Added "getset" to enable quick and easy getters on new structs for better encapsulation.