-
Notifications
You must be signed in to change notification settings - Fork 5k
Makes a few recipes no longer violate rules of matter #12654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
somehow the following recipes were violating the rules of matter and were either creating/destroying matter, by having different input to output ratios instead of it being a 1:1 ratio Mindbreaker (LSD) Zombie Powder Mute Toxin Chloral Hydrate this is out of line with the rest of the chems so I fixed it
isn't it intentional for chloral hydrate |
Questionable, very questionable. Also come on, they aren't violating anything if you don't know what the units correspond to. |
@Anonus Every single other chemical mix uses a 1:1 ratio in the game. |
What the fuck dude this is a universal law of physics
1 unit === 1 unit, no matter what chemical |
In that case, the following recipes also violate this 'rule' that says they have to be 1:1 ignoring ones that spawn an object, are in this PR, or otherwise don't spawn a reagent:
|
Thanks, I'll go through and fix those ones up to be standardized as well. |
Look, matter isn't being created or destroyed in these situations, the density is changing. Or, you know, whatever. |
https://www.youtube.com/watch?v=21MA_lM8afA It's called molecular packing nerds. |
SS13 chem uses volumes, while actual chemistry uses molar mass. So it doesn't make realistic sense either way. But guess what? The current setup is a concious balance decision. This also ignores that fact that half or more of the chemicals we have logically must be aqueous solutions, not pure chemicals. |
this isn't even a realism issue, it's just that it's kind of stupid from a balance perspective when you have to go through a bunch of work to get the ingredients for some of these and come out with only a teeny amount of the product (this is mainly an issue with zombie powder) |
zombie powder is super strong though. Using it purely as an offensive weapon, you've got an instant effect stun that also mutes, can't be stun broken, and allows you to casually walk through the halls dragging a 'corpse' without anyone batting an eyelash. |
yeah but as it is it's impossible to even use because three carp's worth of meat yields 3~ units of zombie powder and if you're growing those beans then everybody will know you're only using them to make zombie powder |
That's never stopped people from growing 100 potency death nettle. And you can always jsut grow them in the back if you're that paranoid. |
let's look at zombie powder: requires morphine we can just make copper some other hard 2 get reagent or some shit for the balance |
They're like this for balance. Tweak the amounts needed if you're tweaking the amount they output. This should be obvious. This should be incredibly, incredibly obvious. Why did you not use your brain before coding? If you want to make a PR to buff all these dangerous chemicals, go do that. Don't make vague PRs then change your mind and make them suddenly be about balance instead of 'consistency'. |
switch copper for real plasma(not fake plasma) |
Please get rid of fake plasma |
nerdiest pr argument ever |
@bustygoku I personally don't think the balance issue will be a problem but people do, so obviously I need to make changes to balance it so the new values aren't disliked. |
have you literally ever seen a chemist that was able to incorporate zombie powder into his plays at all |
Have you literally ever seen a chemist ask botany for koi beans? (or honestly for any plants at all) Because I have l i t e r a l l y never seen anyone else even bother. It's not a question of "able" it's a question of "can they be bothered asking for them". |
no i haven't because it wont work |
yeah, any average tg metagamer won't give you koibeans unless they themselves are a bad-guy type |
Deliberate balance dwcisions. 👎 |
decisions* fucking phone |
Then we can just nerf the chems too |
QUESTIONABLE |
How is that questionable you nerd |
Because you're essentially just diluting it, making it far harder to use (less zombie powder per bite/sip of poisoned food/drinks, less you can fit in an implant/syringe/etc. |
Then let's find a compromise. |
Leave it as it is? This is a pretty odd thing to want to change - these chems are like this for a balance reason, and on the realism front we're talking about a game where you can put solid lumps of iron into a blender and turn it into a liquid, and a chem system based off volume instead of moles. The only thing I would change is lube. Fuck that shit and it's multiplying of the most horrible chemical known to man. |
you guys are overreacting |
It's not a realism issue that chemistry reactions all result in the same volume as the inputs. Enforcing a 1:1 ratio would be completely arbitrary. |
I'm not so much against this pr, but against goof's reasoning for it. as is everybody else. There is no need to enforce a 1:1 ratio. |
yes lets continue to have next to no consistency in our features that's a great fucking plan |
🧂 |
:pepper: |
Updates tgs/precompile.sh hook to match what is deployed on campbell. rust-lang/cargo/tgstation#12654 has set a policy of setting this to be the latest version-2, which kills any kind of signal this could have ever had. cargo's subcrates like `home` are used in almost any complex rust package, so this basically sets the tone for all packages and all crates published after October 8th. A min compiler version should be based on an actual need to use a specific compiler version because of specific features that version has or bugs that version doesn't have. This is signal. Setting to some evergreen value as a matter of course is not signal, its noise. I will not subject myself or our downstreams to such nonsense.
somehow the following recipes were violating the rules of matter and were either creating/destroying matter, by having different input to output ratios instead of it being a 1:1 ratio
Mindbreaker (LSD)
Zombie Powder
Mute Toxin
Chloral Hydrate
this is out of line with the rest of the chems so I fixed it