Skip to content

Conversation

JohnFulpWillard
Copy link
Member

About The Pull Request

Makes the instrument song importing tgui input text use multiline which means BPM is now on its own line instead of taking the first line of the song with it, getting it cut from the import.

Why It's Good For The Game

Closes #82148

Changelog

🆑
fix: Importing songs into instruments no longer cuts the first line of the song.
/:cl:

@JohnFulpWillard JohnFulpWillard added the GBP: No Update Prevent changes to the user's GBP balance from this PR label Mar 21, 2024
@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Mar 21, 2024
@san7890 san7890 merged commit 47a24fa into tgstation:master Mar 23, 2024
comfyorange added a commit that referenced this pull request Mar 23, 2024
buffyuwu pushed a commit to The-Final-Nights/The-Final-Nights that referenced this pull request Apr 17, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Ports the following TG station PRs:
- [x] tgstation/tgstation#59667
- [x] tgstation/tgstation#61573
- [x] tgstation/tgstation#67455
- [x] tgstation/tgstation#72805
- [x] tgstation/tgstation#74170
- [x] tgstation/tgstation#74650
- [x] tgstation/tgstation#75691
- [x] tgstation/tgstation#76453
- [x] tgstation/tgstation#76751
- [x] tgstation/tgstation#81135
- [x] tgstation/tgstation#81923
- [x] tgstation/tgstation#82152
- [x] tgstation/tgstation#85953
- [x] tgstation/tgstation#85967
- [x] tgstation/tgstation#89470
- [x] tgstation/tgstation#89777
- [x] tgstation/tgstation#90330


## Why It's Good For The Game

<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

jukebox fixes + audio stuff is good...

## Testing Photographs and Procedure
<!-- Include any screenshots/videos/debugging steps of the modified code
functioning successfully, ideally including edge cases. -->
<!-- You can uncomment line 1 @ _maps/_basemap.dm to boot up a test map
that loads much faster. -->
<details>
<summary>Screenshots&Videos</summary>



https://github.com/user-attachments/assets/c5ef5f9c-0f8b-4b16-a9aa-e6a36c04443f



</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl: XeonMations, JJRcop
add: Added a new verb that players can request audio from admins with
add: Admins can now play internet links.
config: More config changes related to roundstart and roundend music.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Jonathan Rubenstein <jrubcop@gmail.com>
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: PeriodicChaos <44913068+PeriodicChaos@users.noreply.github.com>
Co-authored-by: EnnyDaiz <160051896+EnnyDaiz@users.noreply.github.com>
Co-authored-by: harry <me@harryob.live>
Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Musical instruments ignore the first line of notes when importing a song
3 participants