Skip to content

Conversation

SomeRandomOwl
Copy link
Contributor

About The Pull Request

I was requested by one of the game admins over in the TG discord to change the credit from character name to ckey.

Why It's Good For The Game

It's mostly a OOC thing, personally I don't know of a good enough reason to put here other than its a PR someone requested of me.

Changelog

🆑
fix: Music Request Credit shows CKEY instead of character name
/:cl:

@SomeRandomOwl SomeRandomOwl requested a review from ZephyrTFA as a code owner July 11, 2023 07:34
@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Jul 11, 2023
@SomeRandomOwl SomeRandomOwl changed the title Music Request Credits changed to CKEY [NO GBP] Music Request Credits changed to CKEY Jul 11, 2023
@tgstation-server tgstation-server added the GBP: No Update Prevent changes to the user's GBP balance from this PR label Jul 11, 2023
@SomeRandomOwl
Copy link
Contributor Author

I think adding no GBP for this is a smart idea, because its just something stupidly small

@E231kei500bandai
Copy link
Contributor

People were trying to tell you why to use ckeys in the last PR, but I'll try to explain the reasons to you again.
While it may work for crew with static names that people know them by, people with random names or animal names like "monkey (123)" won't be able to credit themselves.
The reason about OOC you said the admins told you is that it's mixing IC and OOC, which should be separate. It doesn't make sense for your characters name to show up like he requested it IC, since the music only exists OOC.

@SomeRandomOwl
Copy link
Contributor Author

SomeRandomOwl commented Jul 11, 2023

I know, i just have seen a few people who get upset from their CKEY being displayed to others and just eh i dunno, i was trying to appease both sides since i really personally dont care either way. But adding onto this with the week that my change was merged i have also seen people questioning why it shows character name too and just theres no winning whatever i do so i think just flat out doing CKEY is fine

@ZephyrTFA
Copy link
Contributor

This never should have been mob name and always ckey regardless.
I understand that certain downstreams want to have your ckey and who you are be not linked, but requesting music is literally an OOC thing.

@ZephyrTFA ZephyrTFA merged commit 2a77d87 into tgstation:master Jul 12, 2023
comfyorange added a commit that referenced this pull request Jul 12, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Jul 12, 2023
…6750)

Original PR: tgstation/tgstation#76751
-----
## About The Pull Request

I was requested by one of the game admins over in the TG discord to
change the credit from character name to ckey.

## Why It's Good For The Game

It's mostly a OOC thing, personally I don't know of a good enough reason
to put here other than its a PR someone requested of me.

## Changelog

:cl:
fix: Music Request Credit shows CKEY instead of character name
/:cl:

---------

Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com>
@TheVekter
Copy link
Contributor

TheVekter commented Jul 18, 2023

I was the one who originally requested this and did so because I played a song where the person wanted to be credited and it said "Wraith (539) requested..." which had the lovely effect of telling literally everyone there was a cult.

Thankfully, the cult was already exceedingly loud at this point, but this PR fixes the issue wholesale. Thank you for doing this.

@SomeRandomOwl SomeRandomOwl deleted the music-naming branch July 23, 2023 22:59
buffyuwu pushed a commit to The-Final-Nights/The-Final-Nights that referenced this pull request Apr 17, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Ports the following TG station PRs:
- [x] tgstation/tgstation#59667
- [x] tgstation/tgstation#61573
- [x] tgstation/tgstation#67455
- [x] tgstation/tgstation#72805
- [x] tgstation/tgstation#74170
- [x] tgstation/tgstation#74650
- [x] tgstation/tgstation#75691
- [x] tgstation/tgstation#76453
- [x] tgstation/tgstation#76751
- [x] tgstation/tgstation#81135
- [x] tgstation/tgstation#81923
- [x] tgstation/tgstation#82152
- [x] tgstation/tgstation#85953
- [x] tgstation/tgstation#85967
- [x] tgstation/tgstation#89470
- [x] tgstation/tgstation#89777
- [x] tgstation/tgstation#90330


## Why It's Good For The Game

<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

jukebox fixes + audio stuff is good...

## Testing Photographs and Procedure
<!-- Include any screenshots/videos/debugging steps of the modified code
functioning successfully, ideally including edge cases. -->
<!-- You can uncomment line 1 @ _maps/_basemap.dm to boot up a test map
that loads much faster. -->
<details>
<summary>Screenshots&Videos</summary>



https://github.com/user-attachments/assets/c5ef5f9c-0f8b-4b16-a9aa-e6a36c04443f



</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl: XeonMations, JJRcop
add: Added a new verb that players can request audio from admins with
add: Admins can now play internet links.
config: More config changes related to roundstart and roundend music.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Jonathan Rubenstein <jrubcop@gmail.com>
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: PeriodicChaos <44913068+PeriodicChaos@users.noreply.github.com>
Co-authored-by: EnnyDaiz <160051896+EnnyDaiz@users.noreply.github.com>
Co-authored-by: harry <me@harryob.live>
Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants