Request Internet Sound Optional Credit User #76453
Conversation
|
ok all the CI checks just failed for some reason, going to fix it |
|
Why is this using character name over ckey? |
|
For user privacy mostly, not everyone wants their CKEY publicized. If a maintainer requests otherwise though I can configure it to do CKEY instead like it does for admins. |
I just don't see a point in attributing it to a player's character name when music isn't diagetic. Requests are made by players, not their characters. Ckey privacy isn't an issue in-game because everyone can see everyone else's ckey by just using the "who" verb. |
Again, if a maintainer agrees, then its a simple change that I am willing to make. I have just been bitten on this before because some people are sensitive on CKEY, though I do suppose it has a option to be anonymous and people can just use that, which is the default. |
There was a problem hiding this comment.
the ckey and character name are inextricably linked on /tg/ production servers due to public logging and scrubby, it is incredibly simple to link the two if anyone really wants to. the only viable option between the two is either always show the ckey, or do it as it currently is (ckey before round, character name during).
i suggested something to make it a little less ambiguous (especially since a ckey isn't really a user-facing concept, typically I always say "BYOND Account Name"), and it should help out a bit should someone have a stronger opinion on this than I do who wants you to always play the ckey.
otherwise, nits.
|
If they want to maintain their privacy, wouldn't they just choose to not display their name when requesting the song? |
|
I suppose yea |
|
@san7890 was there any further changes you wanted? |
) Original PR: tgstation/tgstation#76453 ----- ## About The Pull Request What this PR does is it adds a small additional feature to the Request Internet Sound verb to give users who request music an option to credit themselves for the song request. It will use character name of the person who submits the request, with the option to be anonymous. The default will make users anonymous. ## Why It's Good For The Game This differentiates songs that where requested by users and songs that admins themselves played. And allows users to give themselves credit for their 'Good' (or bad) music preferences. <details> <summary>Screenshot</summary>  </details> ## Changelog :cl: qol: Request Internet Sound now has the option to credit the person who requested the Sound. Defaults to anonymous. /:cl: --------- Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Ports the following TG station PRs: - [x] tgstation/tgstation#59667 - [x] tgstation/tgstation#61573 - [x] tgstation/tgstation#67455 - [x] tgstation/tgstation#72805 - [x] tgstation/tgstation#74170 - [x] tgstation/tgstation#74650 - [x] tgstation/tgstation#75691 - [x] tgstation/tgstation#76453 - [x] tgstation/tgstation#76751 - [x] tgstation/tgstation#81135 - [x] tgstation/tgstation#81923 - [x] tgstation/tgstation#82152 - [x] tgstation/tgstation#85953 - [x] tgstation/tgstation#85967 - [x] tgstation/tgstation#89470 - [x] tgstation/tgstation#89777 - [x] tgstation/tgstation#90330 ## Why It's Good For The Game <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> jukebox fixes + audio stuff is good... ## Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- You can uncomment line 1 @ _maps/_basemap.dm to boot up a test map that loads much faster. --> <details> <summary>Screenshots&Videos</summary> https://github.com/user-attachments/assets/c5ef5f9c-0f8b-4b16-a9aa-e6a36c04443f </details> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: XeonMations, JJRcop add: Added a new verb that players can request audio from admins with add: Admins can now play internet links. config: More config changes related to roundstart and roundend music. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Jonathan Rubenstein <jrubcop@gmail.com> Co-authored-by: san7890 <the@san7890.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com> Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: PeriodicChaos <44913068+PeriodicChaos@users.noreply.github.com> Co-authored-by: EnnyDaiz <160051896+EnnyDaiz@users.noreply.github.com> Co-authored-by: harry <me@harryob.live> Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
About The Pull Request
What this PR does is it adds a small additional feature to the Request Internet Sound verb to give users who request music an option to credit themselves for the song request. It will use character name of the person who submits the request, with the option to be anonymous. The default will make users anonymous.
Why It's Good For The Game
This differentiates songs that where requested by users and songs that admins themselves played. And allows users to give themselves credit for their 'Good' (or bad) music preferences.
Screenshot
Changelog
🆑
qol: Request Internet Sound now has the option to credit the person who requested the Sound. Defaults to anonymous.
/:cl: