Update the Play Internet Sound Verb #72805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes it to expose additional metadata as well as remove unused Metadata that wasn't provided by youtube-dl, It also changes the widget itself to display a little extra info on the currently playing track, it also changes the data for when the show song title dialog box is responded with no, it will keep the at a glance info for the song still hidden but still provide the link
|
Going to add another feature in later tonight, at the suggestion from other staff over at sky rat. But they requested a second popup to ask if you want to remain anonymous completely I.E. It keeps the link still hidden but it shows who played the song, or it doesnt show anything at all in chat |
|
Alright i added in the prompt they asked for: Screenshots |
san7890
reviewed
Jan 19, 2023
Co-authored-by: san7890 <the@san7890.com>
san7890
reviewed
Jan 19, 2023
|
remove the ability to hide the name of the song i'm tired of having to ahelp and get told darude sandstorm |
Co-authored-by: san7890 <the@san7890.com>
I mean, that was my original intention for this, but i should see what a maintainer thinks, because im willing to do both ways, but id prefer to always show the URL as well, as people ahelp alot for songs if we hide them, but i do have some people who also asked me to hide the link always when the hidden choice is picked. so im not really sure what would be the best solution. |
| const dispatch = useDispatch(context); | ||
| const settings = useSettings(context); | ||
| const title = audio.meta?.title; | ||
| const audio = useSelector(context, selectAudio), |
There was a problem hiding this comment.
Do not use commas to bundle together consts, keep them each with their own const keywords.
There was a problem hiding this comment.
Might i ask why? Im not arguing, but im asking how come? I have been programming JS stuff for a while now and have always done it this way and it makes me curious why you say otherwise?
There was a problem hiding this comment.
From what i know
const var1; const var2; const var3;
is the Exact same as
const var1,var2,var3
it just cleans things up and has things displayed more neatly as having all the extra characters for the other consts is unnecessary where logically both function the same
|
always wanted the ability to show people who was playing the songs, good PR |
Fikou
reviewed
Jan 19, 2023
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
comfyorange
added a commit
that referenced
this pull request
Jan 19, 2023
Jolly-66
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
Jan 19, 2023
Original PR: tgstation/tgstation#72805 ----- ## About The Pull Request This changes it to expose additional metadata as well as remove unused Metadata that wasn't provided by youtube-dl, It also changes the widget itself to display a little extra info on the currently playing track. Also adds in a new prompt to either show or hide the name of the admin who played the music ## Why It's Good For The Game It will now show additional info to players when a admin plays a song using the verb, such as making the link always available to the player so if they like the song they dont need to ask for the link, as well as other info that might be scraped by youtube-dl so players know if you simply queued a 2 minute long song or a 10 minute long one as well other simple info such as artist and album if that info is available. And now there is the option to show players who played songs, or to keep it anonymous <details> <summary>Screenshots</summary>      </details> ## Changelog :cl: admin: Modified the Play Internet Sound Verb so it now displays extra info about any song being actively played as well as showing the link /:cl: Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com> Co-authored-by: san7890 <the@san7890.com> Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
1 task
Merged
17 tasks
buffyuwu
pushed a commit
to The-Final-Nights/The-Final-Nights
that referenced
this pull request
Apr 17, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Ports the following TG station PRs: - [x] tgstation/tgstation#59667 - [x] tgstation/tgstation#61573 - [x] tgstation/tgstation#67455 - [x] tgstation/tgstation#72805 - [x] tgstation/tgstation#74170 - [x] tgstation/tgstation#74650 - [x] tgstation/tgstation#75691 - [x] tgstation/tgstation#76453 - [x] tgstation/tgstation#76751 - [x] tgstation/tgstation#81135 - [x] tgstation/tgstation#81923 - [x] tgstation/tgstation#82152 - [x] tgstation/tgstation#85953 - [x] tgstation/tgstation#85967 - [x] tgstation/tgstation#89470 - [x] tgstation/tgstation#89777 - [x] tgstation/tgstation#90330 ## Why It's Good For The Game <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> jukebox fixes + audio stuff is good... ## Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- You can uncomment line 1 @ _maps/_basemap.dm to boot up a test map that loads much faster. --> <details> <summary>Screenshots&Videos</summary> https://github.com/user-attachments/assets/c5ef5f9c-0f8b-4b16-a9aa-e6a36c04443f </details> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: XeonMations, JJRcop add: Added a new verb that players can request audio from admins with add: Admins can now play internet links. config: More config changes related to roundstart and roundend music. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Jonathan Rubenstein <jrubcop@gmail.com> Co-authored-by: san7890 <the@san7890.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com> Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: PeriodicChaos <44913068+PeriodicChaos@users.noreply.github.com> Co-authored-by: EnnyDaiz <160051896+EnnyDaiz@users.noreply.github.com> Co-authored-by: harry <me@harryob.live> Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This changes it to expose additional metadata as well as remove unused Metadata that wasn't provided by youtube-dl, It also changes the widget itself to display a little extra info on the currently playing track.
Also adds in a new prompt to either show or hide the name of the admin who played the music
Why It's Good For The Game
It will now show additional info to players when a admin plays a song using the verb, such as making the link always available to the player so if they like the song they dont need to ask for the link, as well as other info that might be scraped by youtube-dl so players know if you simply queued a 2 minute long song or a 10 minute long one as well other simple info such as artist and album if that info is available.
And now there is the option to show players who played songs, or to keep it anonymous
Screenshots
Changelog
🆑
admin: Modified the Play Internet Sound Verb so it now displays extra info about any song being actively played as well as showing the link
/:cl: