Makes the roundend theme a config #61573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
im mad because this works locally so idk why checks are failing |
|
CC @MrsTonedOne -- files being moved into config |
|
I'm going to wait until @MrsTonedOne has confirmed these are all moved over |
|
or maybe do it myself later |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
@Mothblocks Any update on this? |
|
mso is busy with forums so i'll have to do it myself |
|
actually i dont even think i have the ability to network link stuff |
|
|
I'll look into it, to learn if nothing else |
|
Done |
Merged
17 tasks
buffyuwu
pushed a commit
to The-Final-Nights/The-Final-Nights
that referenced
this pull request
Apr 17, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Ports the following TG station PRs: - [x] tgstation/tgstation#59667 - [x] tgstation/tgstation#61573 - [x] tgstation/tgstation#67455 - [x] tgstation/tgstation#72805 - [x] tgstation/tgstation#74170 - [x] tgstation/tgstation#74650 - [x] tgstation/tgstation#75691 - [x] tgstation/tgstation#76453 - [x] tgstation/tgstation#76751 - [x] tgstation/tgstation#81135 - [x] tgstation/tgstation#81923 - [x] tgstation/tgstation#82152 - [x] tgstation/tgstation#85953 - [x] tgstation/tgstation#85967 - [x] tgstation/tgstation#89470 - [x] tgstation/tgstation#89777 - [x] tgstation/tgstation#90330 ## Why It's Good For The Game <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> jukebox fixes + audio stuff is good... ## Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- You can uncomment line 1 @ _maps/_basemap.dm to boot up a test map that loads much faster. --> <details> <summary>Screenshots&Videos</summary> https://github.com/user-attachments/assets/c5ef5f9c-0f8b-4b16-a9aa-e6a36c04443f </details> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: XeonMations, JJRcop add: Added a new verb that players can request audio from admins with add: Admins can now play internet links. config: More config changes related to roundstart and roundend music. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Jonathan Rubenstein <jrubcop@gmail.com> Co-authored-by: san7890 <the@san7890.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com> Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: PeriodicChaos <44913068+PeriodicChaos@users.noreply.github.com> Co-authored-by: EnnyDaiz <160051896+EnnyDaiz@users.noreply.github.com> Co-authored-by: harry <me@harryob.live> Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This isn't the song that plays at the end of a round (which is actually just the roundstart song played again), but the little few second theme that plays when a server reboots.
This sets it to use the same thing title music does.
Why It's Good For The Game