Throw exception when option is overridden #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
commented
Jun 25, 2024
| emitWarnings = | ||
| let toWarnings o l = | ||
| fmap (uncurry . flip $ DuplicateOption.DuplicateOption o) | ||
| . reverse |
There was a problem hiding this comment.
I should refactor this to avoid reverse.
There was a problem hiding this comment.
Turns out this is not worth the trouble. Plus usually the list will have one or two elements here.
|
Note that this is a change in behavior since previously some places that would throw an exception will now merely emit a warning. |
|
I think it would be better to avoid changing any existing behavior and instead only add new warnings. That way this won't have to be a breaking change, and I can focus on improving the CLI later. |
|
I'm now wondering if I should scrap this as well and just throw a warning in this case instead of an error. Not sure why I didn't consider that before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80.
Previously if you passed the same option twice, Gild would silently ignore the first one and use the second one. For example:
# cabal-gild -i x -i yThat command will use
yfor input and ignorex.This PR changes the behavior so that Gild will throw an exception in situations like the above. For example:
# cabal-gild -i x -i y overriding option --input (before: x, after: y)