Remove obsolete wrapper types #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
commented
Mar 4, 2025
| import qualified Data.Ord as Ord | ||
| import qualified Distribution.FieldGrammar.Newtypes as Newtypes | ||
| import qualified Distribution.Parsec as Parsec | ||
| import qualified Distribution.Pretty as Pretty | ||
|
|
||
| -- | This type exists to provide an 'Ord' instance for 'Newtypes.TestedWith', | ||
| -- which was added in @Cabal-syntax-3.10.1.0@. | ||
| -- | This type exists to provide an 'Ord' instance for 'Newtypes.TestedWith'. |
There was a problem hiding this comment.
This type does not have an Ord instance at all: https://hackage.haskell.org/package/Cabal-syntax-3.14.1.0/docs/Distribution-FieldGrammar-Newtypes.html#t:TestedWith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many wrapper types that only exist to provide instances that were missing before
Cabal-syntaxversion 3.10.1.0. After #112 (actually really #75), those versions aren't supported anymore so the wrapper types can be removed. That's what this PR does. There should be no change in behavior.