Skip to content

if stdin is a terminal use the cabal file in the cwd #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

if stdin is a terminal use the cabal file in the cwd #100

wants to merge 4 commits into from

Conversation

BebeSparkelSparkel
Copy link
Contributor

@BebeSparkelSparkel BebeSparkelSparkel commented Jul 20, 2024 •
edited
Loading

closes #97

@tfausak tfausak added the enhancement New feature or request label Jul 25, 2024
tfausak
tfausak reviewed Jul 26, 2024
View reviewed changes
Copy link
Owner

@tfausak tfausak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! It would be nice to have a test for this new behavior.

@BebeSparkelSparkel
Copy link
Contributor Author

Looking good so far! It would be nice to have a test for this new behavior.

I don't write tests until things are looking good, so I'll fix the above issues and then add tests if you like what's been done.

@BebeSparkelSparkel
Copy link
Contributor Author

Added some tests.

tfausak added a commit that referenced this pull request Mar 6, 2025
@tfausak
Refactor changes from #100
576ca04
@tfausak tfausak mentioned this pull request Mar 6, 2025
Merged
@tfausak
Copy link
Owner

tfausak commented Mar 6, 2025

Thanks so much for opening this PR! Sorry for the absolutely glacial response time.

I had some feedback about the tests. Rather than going through a back-and-forth, I opened a PR with my changes: #119. I intended for that to be merged into this one, but I don't know how to do that. At any rate, I didn't introduce any functional changes to your code. I just changed the test code to avoid using the main-tester package.

tfausak added a commit that referenced this pull request Mar 9, 2025
@tfausak @BebeSparkelSparkel
Use package description from current directory when STDIN is a termin…
4f111ff 
…al (#119)

* if stdin is a terminal use the cabal file in the cwd

* ormolu

* remove directory dependency, fail if more than one cabal file, move logic to Context.fromConfig

* added cwd cabal file tests

* Refactor changes from #100

---------

Co-authored-by: William Rusnack <williamrusnack@gmail.com>
@tfausak tfausak closed this in #119 Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfausak tfausak tfausak left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to use cabal file in CWD
2 participants
@BebeSparkelSparkel @tfausak