test(config-loader): add user config is true case
#1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a test scenario for when a user explicitly enables a preset rule (c1) in the config loader.
- Input fixture now includes
"c1": trueunder rules. - Module fixture exposes two sub-rules (
c1,c2) in the preset. - Snapshot updated to expect two entries for those rules with preserved severities.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/@textlint/config-loader/test/snapshots/preset-severity-preservation/input.json | Added "c1": true to simulate user-enabling rule |
| packages/@textlint/config-loader/test/modules_fixtures/textlint-rule-preset-abc-with-severity/index.js | Exposed c1 and c2 in preset rules and configs |
| packages/@textlint/config-loader/test/snapshots/preset-severity-preservation/output.json | Updated snapshot to include c1 and c2 entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test case for config loader