-
-
Notifications
You must be signed in to change notification settings - Fork 33
Add true colour RGB option as input arguments #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 97.65% 97.79% +0.13%
==========================================
Files 3 3
Lines 128 136 +8
==========================================
+ Hits 125 133 +8
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you add tests and an example to the README?
specify that ints are 0-255 Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
this spans all 256**3 permutations
256**3 permutations was too ridiculously long
for more information, see https://pre-commit.ci
I've added tests for the README has also been edited as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Yeah, just a couple of representative values are fine 😅
Thanks! |
Cool, hope to see it merged! Am looking to use this in my own mini libraries. |
Hi there, I really like this package but wanted the ability to print in any arbitrary RGB colour. Since most terminals now (even Windows Terminal) allow for 24-bit RGB, I think this would be a useful addition.
I'm not sure what else I would need to change for this to be accepted (or if this is even desired as a feature). Let me know and I'll amend it!
Preview of the feature (added to main.py):