Replace literal types with strings #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 3 3
Lines 125 125
=======================================
Hits 122 122
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b6fdd84 to
36bee61
Compare
agoscinski
added a commit
to C2SM/Sirocco
that referenced
this pull request
May 6, 2025
Replace the `Color` type by `str` as it does not exist in termcolor. The mypy issue is due to a recent change in termcolor from the PR termcolor/termcolor#97
agoscinski
added a commit
to C2SM/Sirocco
that referenced
this pull request
May 6, 2025
Replace the `Color` type by `str` as it does not exist in termcolor. The mypy issue is due to a recent change in termcolor from the PR termcolor/termcolor#97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62.