Fix some compiler warnings #4245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
- Use conditional compilation for variables which might be useful for debugging. - Remove all other unused variables. Signed-off-by: Stefan Weil <sw@weilnetz.de>
This also fixes several compiler warnings ([-Wimplicit-float-conversion], [-Wdouble-promotion]). Signed-off-by: Stefan Weil <sw@weilnetz.de>
egorpugin
reviewed
May 19, 2024
| #define MAX_NODE_EDGES_DISPLAY static_cast<int64_t>(100) | ||
| #define MARKER_FLAG static_cast<int64_t>(1) | ||
| #define DIRECTION_FLAG static_cast<int64_t>(2) | ||
| #define WERD_END_FLAG static_cast<int64_t>(4) |
There was a problem hiding this comment.
Is it possible to replace with inline vars? constexpr inlines?
There was a problem hiding this comment.
Yes, I think so (it the compiler produces the same efficient code). We could consider such a change for more macros in the future.
egorpugin
approved these changes
May 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.