This repository was archived by the owner on May 29, 2024. It is now read-only.
Threat Bus zmq apps use the wrong host name after connection. #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
approved these changes
Jun 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Prior to this change, Threat Bus (the
zmq-appplugin) returned a wronghost:porttuple to zmq apps. It used to send it's own bind IP address, which is not the same as the IP known to the outside world. Now it only sends the ports for pub/sub and leaves it to the apps to bind to the correct endpoint.📝 Checklist
🎯 Review Instructions
Run the integration test.
For interactive testing, run all ZMQ apps individually.