Skip to content

Conversation

jfb54
Copy link

@jfb54 jfb54 commented May 24, 2022

Thank you for your contribution!

Please read https://www.tensorflow.org/datasets/contribute#pr_checklist to make sure your PR follows the guidelines.

Fixed issue 2889 - Loading SUN397 crashed

  • Dataset Name: sun397
  • Issue Reference: Issue 2889

Description

A very small, surgical fix that allows the sun397 dataset to be downloaded and installed without issue. I made two small changes:

  • I added a file that could not be decoded to the pre-existing _SUN397_IGNORE_IMAGES list.
  • Even though the list _SUN397_IGNORE_IMAGES was present in the code, it was never referred to. So all I did was add an if statement in the main decoding loop that would ignore any file in the _SUN397_IGNORE_IMAGES list.

Checklist

  • Run download_and_prepare successfully
  • Lint code

@l1teng
Copy link

l1teng commented Oct 23, 2022

solve my proplem, thanks.

@minhlong94
Copy link

+1 need for this PR.

@JeavanCode
Copy link

Where can I modify the decoding mainloop?

@ccl-core ccl-core self-assigned this Jun 12, 2023
@fineguy
Copy link
Collaborator

fineguy commented Jun 30, 2023

Thank you for your contribution!

I merged a similar PR #4955, so closing this one.

@fineguy fineguy closed this Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants