Skip to content

Conversation

kenwoodjw
Copy link
Contributor

feat #246
Signed-off-by: kenwoodjw

Signed-off-by: GitHub <noreply@github.com>
@gaocegege
Copy link
Member

Please run make fmt to format the code.

Signed-off-by: GitHub <noreply@github.com>
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

pkg/app/up.go Outdated
@@ -93,6 +93,11 @@ var CommandUp = &cli.Command{
Usage: "detach from the container",
Value: false,
},
&cli.BoolFlag{
Name: "no-gpu",
Usage: "launch same cpu container without gpu",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Usage: "launch same cpu container without gpu",
Usage: "launch the CPU container",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: GitHub <noreply@github.com>
@gaocegege
Copy link
Member

LGTM!

Thanks for your contribution! 🎉 👍

@gaocegege gaocegege merged commit 35c6b76 into tensorchord:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants