Skip to content

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Mar 19, 2025

No description provided.

@usamoi usamoi force-pushed the update-20250319 branch 4 times, most recently from e20933e to 7d53c49 Compare March 19, 2025 10:16
@usamoi usamoi requested a review from Copilot March 19, 2025 10:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions and toolchain configurations while refining CI workflows and internal unsafe usage patterns. Key changes include:

  • Upgrading the Rust nightly toolchain and crate dependencies (e.g. pgrx, half, zerocopy, cc).
  • Updating CI workflow download URLs for the cargo‑pgrx binary with a change in target from musl to gnu.
  • Removing redundant derive imports and adjusting unsafe block usage across multiple SIMD modules.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rust-toolchain.toml Updated nightly channel to "nightly-2025-03-19".
Cargo.toml Updated crate edition and dependency versions (pgrx, half, zerocopy, etc.).
.github/workflows/release.yml Updated cargo‑pgrx download URL (target changed from musl to gnu).
.github/workflows/check.yml Updated cargo‑pgrx download URL (target changed from musl to gnu).
crates/simd*, crates/simd_macros/* Refactored unsafe block usage and updated intrinsic calls.
crates/algorithm/src/tuples.rs Removed redundant zerocopy_derive import.
Comments suppressed due to low confidence (2)

.github/workflows/release.yml:68

  • Switching the target from 'unknown-linux-musl' to 'unknown-linux-gnu' may lead to compatibility issues if the deployment environment expects musl binaries. Please verify that this change is intended.
curl -fsSL https://github.com/tensorchord/pgrx/releases/download/v0.13.1/cargo-pgrx-v0.13.1-$(uname -m)-unknown-linux-gnu.tar.gz | tar -xOzf - ./cargo-pgrx | install -m 755 /dev/stdin /usr/local/bin/cargo-pgrx

.github/workflows/check.yml:155

  • Ensure that switching from the musl to gnu target in the cargo‑pgrx binary is compatible with your CI environment in check.yml.
curl -fsSL https://github.com/tensorchord/pgrx/releases/download/v0.13.1/cargo-pgrx-v0.13.1-$(uname -m)-unknown-linux-gnu.tar.gz | tar -xOzf - ./cargo-pgrx | install -m 755 /dev/stdin /usr/local/bin/cargo-pgrx

Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi usamoi merged commit dc12d84 into tensorchord:main Mar 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant