feat: neon impl of u8::reduce_sum_of_x #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: usamoi <usamoi@outlook.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new implementation for u8::reduce_sum_of_x with multiple architecture-specific optimizations. Key changes include:
- Renaming and updating test functions for the v3 implementation.
- Adding a new optimized reduce_sum_of_x_v2 for x86_64 and reduce_sum_of_x_a2 for aarch64.
- Adjusting attributes and inline annotations for improved performance and clarity.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/simd/src/u8.rs | Renamed test function and added new implementations for x86_64 (v2) and aarch64 (a2). |
| crates/simd/src/emulate.rs | Removed a now-unnecessary #[expect(dead_code)] attribute in favor of inline attributes. |
Comments suppressed due to low confidence (2)
crates/simd/src/u8.rs:310
- [nitpick] The test function name changed from reduce_sum_of_x_as_u16_v3_test to reduce_sum_of_x_v3_test. Please confirm that the new name clearly conveys the intent of the test and aligns with the implementation under test.
fn reduce_sum_of_x_v3_test() {
crates/simd/src/u8.rs:367
- [nitpick] Consider extracting the loop iteration count (256 and 1) into a named constant to improve test readability and maintainability.
for _ in 0..if cfg!(not(miri)) { 256 } else { 1 } {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.