feat: build multiarch pgrx image #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <kemingyang@tensorchord.ai>
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- docker/pgrx.Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/pgrx.yml:50
- Ensure that the
channelparameter is correctly passed and utilized in the build-args and tags. Add tests to verify the behavior with differentchannelvalues.
TOOLCHAIN_CHANNEL=${{ github.event.inputs.channel }}
.github/workflows/pgrx.yml:47
- Verify that the
platformsparameter is correctly formatted and ensure that the multi-architecture build works as expected. Add tests to cover the behavior for different platforms.
platforms: "linux/amd64,linux/arm64"
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
usamoi
reviewed
Dec 26, 2024
| needs: ["semver"] | ||
| strategy: | ||
| matrix: | ||
| version: ["14", "15", "16", "17"] | ||
| arch: ["x86_64", "aarch64"] | ||
| runner: ["ubicloud-standard-4", "ubicloud-standard-4-arm"] |
There was a problem hiding this comment.
Suggested change
| runner: ["ubicloud-standard-4", "ubicloud-standard-4-arm"] | |
| arch: ["x86_64", "aarch64"] |
| @@ -33,15 +33,17 @@ jobs: | |||
| core.setOutput('SEMVER', tag); | |||
|
|
|||
| build: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ${{ matrix.runner }} | |||
There was a problem hiding this comment.
Suggested change
| runs-on: ${{ matrix.runner }} | |
| runs-on: ${{ matrix.arch == 'x86_64' && 'ubicloud-standard-4' || 'ubicloud-standard-4-arm' }} |
We could fork and cross compile it. |
Will fork it if they have no response in 24h. |
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
e32fb44 to
c5afe8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqllogictest-rsdoesn't have Linux ARM64 release, tracked here