Fail workflow task with BadSearchAttributes cause if search attributes mapper returned an error #3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fail workflow task with
BadSearchAttributescause if search attributes mapper returned an error.Why?
Just returning an error from
handleCommandscauses workflow task to timeout but not to fail, which is wrong.Failing workflow task allow to write error message to the history and expose error message in WebUI/tctl.
How did you test it?
Upcomming functional tests.
Potential risks
No risks but there is small behaviour change: WTFail event will be written to the history instead of WTTimeout.
Is hotfix candidate?
No.